Looks ok to me... although I confess I'm going to need to brush up on my m4. ;^)
-kto On Nov 14, 2012, at 3:38 AM, Erik Joelsson wrote: > http://cr.openjdk.java.net/~erikj/8001875/webrev.root.01/ > <http://cr.openjdk.java.net/%7Eerikj/8001875/webrev.root.01/> > > This patch changes the configure paramater --disable-static-link-stdc++ to > the following: > > --with-stdc++lib=<static>,<dynamic>,<default> > * default: try static if it works but falling back on dynamic > * static: force static or fail if it doesn't work > * dynamic: force dynamic or fail if it doesn't work > > This only applies to linux. > > Previously configure would just emit a warning that the chosen strategy > didn't work and the other was chosen. I think that if a user actively choses > a strategy for linking, it should be an error if it can't be used. > > This became a problem when trying to compile 32-bit linux binaries on a > 64-bit system and trying to sort out all the library dependencies. > > After applying the patch, remember to run bash common/autoconf/autogen.sh and > to also submit in jdk/make/closed when pushing it in. > > /Erik
