Kelly,
The Makefile changes were reviewed under 7153050 last week and
pushed to RT_Baseline.
See the attached notification.
Dan
On 12/18/12 2:06 PM, Kelly O'Hair wrote:
I don't see any makefile changes.
-kto
On Dec 18, 2012, at 12:46 PM, Daniel D. Daugherty wrote:
Greetings,
I'm sponsoring this code review request from Ron Durbin. This change
is targeted at JDK8/HSX-25 in the RT_Baseline repo.
Dan
Sending again with correct subject line, bug URLs and webrev URL.
Intro:
This set of changes removes the runtimesupport for generation of debug versions
that follow _g semantics.
Defect:
JDK-8005044 remove crufty '_g' support from HS runtime code
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005044
https://jbs.oracle.com/bugs/browse/JDK-8005044
Webrev
http://cr.openjdk.java.net/~dcubed/for_rdurbin/8005044-webrev/0
Details:
Files have been modified to remove all reference and support for debug
versions that follow _g semantics.
Testing:
Passed JPRT last night:
Additional Testing In process: (suggested by Dan):
src/share/vm/runtime/arguments.cpp
- test with shared archive creation and use; see the e-mail
from Coleen
src/share/tools/ProjectCreator/ProjectCreator.java
- just a usage message; visual inspection of the code
src/os/windows/vm/os_windows.cpp
- comments only; no testing needed
src/os/{bsd,linux,solaris}/vm/os_{bsd,linux,solaris}.cpp
- the only code changes come into play when the "gamma"
launcher is used
- and when JAVA_HOME refers to a valid JDK, the function
fakes up a JVM path so that callers using the JVM path
to find other things in the JDK will work.
- I can't find any way that the actual JVM path value
that is returned is exposed
- I don't see a way to test this other than have a debug
printf() or manual code inspection.
--- Begin Message ---
Changeset: 892acf0431ef
Author: dcubed
Date: 2012-12-14 10:06 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/892acf0431ef
7153050: remove crufty '_g' support from HotSpot repo makefiles
Summary: Phase 1 is removing '_g' support from the Makefiles.
Reviewed-by: dcubed, sspitsyn, coleenp, tbell
Contributed-by: ron.dur...@oracle.com
! make/bsd/Makefile
! make/bsd/makefiles/buildtree.make
! make/bsd/makefiles/debug.make
! make/bsd/makefiles/dtrace.make
! make/bsd/makefiles/fastdebug.make
! make/bsd/makefiles/gcc.make
! make/bsd/makefiles/jsig.make
! make/bsd/makefiles/jvmg.make
! make/bsd/makefiles/optimized.make
! make/bsd/makefiles/product.make
! make/bsd/makefiles/saproc.make
! make/bsd/makefiles/vm.make
! make/linux/Makefile
! make/linux/makefiles/buildtree.make
! make/linux/makefiles/debug.make
! make/linux/makefiles/fastdebug.make
! make/linux/makefiles/gcc.make
! make/linux/makefiles/jsig.make
! make/linux/makefiles/jvmg.make
! make/linux/makefiles/optimized.make
! make/linux/makefiles/product.make
! make/linux/makefiles/saproc.make
! make/linux/makefiles/vm.make
! make/solaris/Makefile
! make/solaris/makefiles/buildtree.make
! make/solaris/makefiles/debug.make
! make/solaris/makefiles/dtrace.make
! make/solaris/makefiles/fastdebug.make
! make/solaris/makefiles/gcc.make
! make/solaris/makefiles/jsig.make
! make/solaris/makefiles/jvmg.make
! make/solaris/makefiles/optimized.make
! make/solaris/makefiles/product.make
! make/solaris/makefiles/saproc.make
! make/solaris/makefiles/vm.make
! make/windows/build.make
! make/windows/projectfiles/compiler2/ADLCompiler.dsp
! make/windows/projectfiles/tiered/ADLCompiler.dsp
--- End Message ---
