In the past, the "-encoding ascii" was important, all the reasons I can't completely list right now. But it is important that regardless of the locale, the bits created during the build should be the same for everyone. The definition of "same" might not be bit for bit, but by minimizing the potential differences we have a fighting chance of measuring "the same".
But my question is, how are any locale specific characters getting into generated sources? That's what we need to find out. Removing "-encoding ascii" is probably not the right answer, and if it is, will require some debate. -kto On Dec 30, 2012, at 9:25 PM, Frank Ding wrote: > Hi > I have an encoding problem when building openjdk 8 on my Windows 7. My > windows is Chinese environment but I exported LANG=C in cygwin bash before > building. The issue is that in module corba and jdk, some java classes are > generated by program. They happen to contain Chinese characters in comment. > However, they are compiled with explicit option "-encoding ascii" in > makefile. This results in unrecognizable chars complained by javac (Error: > encoding ascii unmappable chars) . I have a patch that removes all > unnecessary "-encoding ascii" but I am not sure all its side effect. Shall I > submit a bug? > > Best regards, > Frank >
