Hi Fredrik,
> It seems to be reasonable that these sources should be part of the
> src.zip and that it was a bug previously that they were not.
I don't think so.
First, *BeanInfo classes must be packed to dt.jar, not rt.jar. So, it
will be strange to provide sources for nonexistent (by default) classes.
Second, *BeanInfo java files are generated automatically. They are not
well-formatted and well-documented.
Thanks,
SAM
On 07.01.2013 19:59, Fredrik Öhrström wrote:
2012/12/18 Sergey Malenkov <sergey.malen...@oracle.com>:
Looks OK to me. But there are a lot of images in the
make/tools/swing-beans/beaninfo/images folder. Could you please check the
make/javax/swing/beaninfo/SwingBeans.gmk file to ensure that the dt.jar
library will be packed correctly?
Yes, I have verified that the gifs are in the same folder.
Also I think that moving of java files from the
make/tools/swing-beans/beaninfo folder is redundant, because we could copy
them to the expected folder from the current location.
Yes, copying to a temporary, correct package directory, would work. But I think
it is better to move them into the correct package directory, it is simpler
and cleaner.
However here is another question. With this change,
the following 46 source files appear in src.zip:
/javax/swing/AbstractButtonBeanInfo.java
/javax/swing/BoxBeanInfo.java
---- 8< ----
javax/swing/SwingBeanInfoBase.java
/javax/swing/text/JTextComponentBeanInfo.java
It seems to be reasonable that these sources should be part of the
src.zip and that it was a bug previously that they were not.
Can you confirm this Sergey?
//Fredrik
