On 2013-03-28 04:41, David Holmes wrote:
On 27/03/2013 10:58 PM, Erik Joelsson wrote:
On 2013-03-27 13:20, David Holmes wrote:
On 27/03/2013 8:59 PM, Erik Joelsson wrote:
I found the problem and fixed it:
http://cr.openjdk.java.net/~erikj/8010908/webrev.jdk.01/
I don't understand - how did this:
`$(FIND) $(JDK_OUTPUTDIR)/bin -type f -name \*$(EXE_SUFFIX)`
match .debuginfo files but not .diz files (EXE_SUFFIX is empty) ???
It didn't, that was handled by the file command and grep. The problem is
file output is more or less the same for the executable and the
debuginfo file, but at least those can be separated by name.
Ah! Got it - thanks.
So is this line buggy anyway:
ALL_BIN_LIST := $(filter-out %.debuginfo %.diz, $(ALL_BIN_LIST))
I thought you could only have a single wildcard.
I wasn't sure, but I added some debug printing around it and verified
that it actually works. Both patterns are filtered out.
/Erik
David
-----
/Erik
David
/Erik
On 2013-03-27 11:12, Erik Joelsson wrote:
I just tried this and the failure reproduces for me. Will
investigate.
/Erik
On 2013-03-27 01:56, Bharadwaj Yadavalli wrote:
Hi David,
Thanks for the suggestion.
On 3/7/2013 7:54 PM, David Holmes wrote:
I think this is a bug in Images.gmk:
ifneq ($(OPENJDK_TARGET_OS),windows)
ALL_BIN_LIST := $(filter-out %.debuginfo %.diz,
$(ALL_BIN_LIST))
else
You can only have a single wildcard in a pattern so I don't think
that expands the way the author intended.
Can you try editing jdk/makefiles/Images.gmk and changing the
above to:
ifneq ($(OPENJDK_TARGET_OS),windows)
ALL_BIN_LIST := $(filter-out %.debuginfo, $(ALL_BIN_LIST))
ALL_BIN_LIST := $(filter-out %.diz, $(ALL_BIN_LIST))
else
Sadly, that change did not help. I still get the same failure
message
while building jdk8/tl (or lambda repo).
Regards,
Bharadwaj
On 8/03/2013 3:32 AM, Bharadwaj Yadavalli wrote:
I pulled down jdk/tl tree and configured it using the following
command
line:
sh configure --with-debug-level=slowdebug
--with-boot-jdk=/path/to/installed/jdk7 --disable-zip-debug-info
and built by running
make all
I get the following build error
Ignoring (other) javax.xml.ws.wsaddressing.package-info : <any>
ClassSymbol <any>
Creating images/lib/ct.sym
gmake[2]: *** No rule to make target
`/path/to/jdk8/workspace/build/linux-x86_64-normal-server-slowdebug/images/_strip_jre/bin/jarsigner.debuginfo.stripped',
needed by `jre-image'. Stop.
gmake[2]: *** Waiting for unfinished jobs....
gmake[1]: *** [images] Error 2
make: *** [images-only] Error 2
The build does not have any problems if I do not specify
--disable-zip-debug-info
Do I need to specify some other option along with
--disable-zip-debug-info?
Thanks for your help,
Bharadwaj
