Please hold your fire! This is not a suggestion to about general handling of warnings during the build, just a specific gripe I have when trying to find genuine build failures among the noise.

Would there be any objection to adding '-overrides' to the jdk build?

This lint warning was added after the new build was introduced. I suspect it would have been suppressed originally if it was supported at the time.

diff --git a/makefiles/Setup.gmk b/makefiles/Setup.gmk
--- a/makefiles/Setup.gmk
+++ b/makefiles/Setup.gmk
@@ -23,7 +23,7 @@
 # questions.
 #

-DISABLE_WARNINGS:=-Xlint:all,-deprecation,-unchecked,-rawtypes,-cast,-serial,-dep-ann,-static,-fallthrough,-try,-varargs,-empty,-finally
+DISABLE_WARNINGS:=-Xlint:all,-deprecation,-unchecked,-rawtypes,-cast,-serial,-dep-ann,-static,-fallthrough,-try,-varargs,-empty,-finally,-overrides

# The generate old bytecode javac setup uses the new compiler to compile for the
 # boot jdk to generate tools that need to be run with the boot jdk.

-Chris.

P.S. how to handle warnings generally will have to be addressed at some point, but I am not making any proposal at this time.

Reply via email to