Omair,
Since this entirely affects a 2D component, please include 2d-dev in
this discussion.
I would have been 'surprised' to see this change if I hadn't just
spotted this thread.
And I believe this change should be integrated via the 2D forest.
Yes, please support the old build system.
I am not sure what, if any, runtime problems might occur from using a
different
version. We've generally been able to swap in newer versions of ICU without
much trouble, but I recommend to run appropriate tests before shipping ..
Note that JDK8 in fact has a very "current" ICU with some security fixes.
So I would not recommend using the native lib on a system with an older ICU.
-phil.
On 6/5/2013 2:21 AM, Erik Joelsson wrote:
Hello,
Is it required to remove the font/layout dir to use the system
version? I would expect USE_EXTERNAL_ICU_LE=true would add an exclude
for that directory to SetupNativeCompilation,BUILD_LIBFONTMANAGER.
If you expect to delete the source tree on your side, why not have
configure check for the existence of the font/layout directory to
determine the default behavior for system vs bundled?
It seems you forgot to add USE_EXTERNAL_ICU_LE to spec.gmk.in.
Are ICU_LE_CFLAGS and ICE_LE_LIBS supposed to be empty?
/Erik
On 2013-06-04 23:30, Omair Majid wrote:
Hi,
webrev:
http://cr.openjdk.java.net/~omajid/webrevs/system-icu/00/
This implements support for linking against the system-installed ICU
instead of building and linking against the bundled copy of ICU in
OpenJDK8. Now someone building OpenJDK can delete the .../font/layout
directory and use configure to build completely against the system
headers and libraries.
I had to move SunLayoutEngine.cpp so the #include would be "layout/..",
which is where the system-installed ICU headers are. It now also matches
the class name (which is sun.font.SunLayoutEngine, not
sun.font.layout.SunLayoutEngine).
I tried to keep all new ICU-related changes next to the existing
freetype-using-logic since they are both text related.
FYI: I am quite sure the build breaks if built using the old build
system; I will fix that next.
Any comments or suggestions?
Thanks,
Omair
