On 2013-06-17 05:35, David Holmes wrote:
Hi Erik,
In:
CFLAGS_JDK="$CFLAGS_JDK $CFLAGS_DEBUG_SYMBOLS"
why the quoting? And why not use:
CFLAGS_JDK += "$CFLAGS_DEBUG_SYMBOLS"
I wasn't aware that the += operator was valid in shell script, but a bit
of googling revealed that at least in bash it would work. I just
followed the same style that the rest of the configure script input
files use.
/Erik
?
David
On 14/06/2013 9:24 PM, Erik Joelsson wrote:
Thanks, unfortunately I made a type in that patch. Corrected version:
http://cr.openjdk.java.net/~erikj/8014404/webrev.root.02/
The intention was to add to CFLAGS_JDK and CXXFLAGS_JDK, not overwrite
them.
/Erik
On 2013-06-13 15:33, Tim Bell wrote:
Erik:
When configuring with --enable-debug, no -g flag is added to the jdk
native compilations. This patch fixes this and tries to mimic the
settings of -g and optimization flags with the old build as close as
I could manage.
http://cr.openjdk.java.net/~erikj/8014404/webrev.root.01
Looks good.
Tim
