Hi Erik,
On 20/06/2013 6:07 PM, Erik Joelsson wrote:
Simple patch removing unnecessary check for existence of mercurial for
getting the hgtips for the release file. This check prevented the backup
solution of using the .hgtip files from working when building from
source bundles.
http://cr.openjdk.java.net/~erikj/8012564/webrev.root.01/
The change seems okay, but I'm unclear from here:
define GetSourceTips
$(CD) $(SRC_ROOT) ; \
for i in $(REPO_LIST) IGNORE ; do \
if [ "$${i}" = "IGNORE" ] ; then \
continue; \
elif [ -d $${i}/$(HG_DIRECTORY) -a "$(HG_VERSION)" != "" ] ; then \
$(PRINTF) " %s:%s" \
"$${i}" `$(HG) tip --repository $${i} --template
'{node|short}\n'` ; \
elif [ -f $${i}/$(HGTIP_FILENAME) ] ; then \
$(PRINTF) " %s:%s" \
"$${i}" `$(CAT) $${i}/$(HGTIP_FILENAME)` ; \
fi; \
done >> $@
$(PRINTF) "\n" >> $@
endef
what happens if hg does not exist? Will HG_VERSION be empty in that case
so we branch to the HGTIP_FILENAME section?
Thanks,
David
/Erik
