Erik, Thanks for fixing this in this way - much appreciated.
One thing I want to flag. In hotspot we have to add .PHONY entries for all files that we might -include, otherwise make tries to create them by executing a bunch of implicit rules, one of which triggers premature execution of the precompiled headers logic.
Now the main build may not have this problem, but I would think make wastes a lot of time attempting to build a missing include file when we don't want it to even attempt that. So the .PHONY should improve performance.
David On 24/06/2013 9:57 PM, Erik Joelsson wrote:
Please review this simple patch, removing copying of jfr files from CopyFiles.gmk and adding an optional include of a custom CopyFiles.gmk. http://cr.openjdk.java.net/~erikj/8017114/webrev.jdk.01/ /Erik
