Erik:
Thanks for the reminder. This looks good. Approved.
Tim
Would be great if someone could look at this, thanks.
/Erik
On 2013-06-18 12:21, Erik Joelsson wrote:
Thanks,
I hit another problem after fixing this though. On windows, when
building the sec-bin.zip, the root directory for the zip is
$(JDK_OUTPUTDIR), which at the time contains something around 49k
files. This proves too much for cygwin gnu make to handle and it
crashes with a core dump.
I have tweaked SetupZipArchive further to avoid running find over
that many files when possible and it seems to work correctly. The
risk would be the find command line getting too long, but I doubt
that will happen here.
http://cr.openjdk.java.net/~erikj/8016605/webrev.root.02/
/Erik
On 2013-06-14 15:58, Tim Bell wrote:
Erk-
That was a subtle one. I had to look at the unified diffs to see it.
Looks good.
Tim
On 06/14/13 04:18 AM, Erik Joelsson wrote:
I found the problem. Missing commas in a macro call caused the list
of sources to end up empty which made src.zip depend on nothing.
Corrected one other instance having the same problem. (The other
instance was also about dependency calculation but I doubt anybody
had run into trouble with that one yet.)
http://cr.openjdk.java.net/~erikj/8016605/webrev.root.01/
/Erik
On 2013-06-14 11:09, Erik Joelsson wrote:
I must have missed that mail, sorry. I've filed "8016605: New
files dont apear in src.zip"
/Erik
On 2013-06-14 10:48, Boaz Nahum wrote:
Hi.
Sorry I'm raising it again but it is (very) annoying
I'm building lambda/lambda on daily basis.
The problem is that I don't delete src.zip it is not update in
jdk image
Sure make clean solve the problem.
Please see
http://mail.openjdk.java.net/pipermail/build-dev/2013-April/008721.html
Thanks
Boaz
