On 2013-08-07, at 18:22, Alan Bateman <alan.bate...@oracle.com> wrote:

> On 07/08/2013 14:44, Mike Duigou wrote:
>> Hello all;
>> 
>> This changesest simplifies how the the jdk/test/Makefile processes excluded 
>> tests. Previously the test exclusions were pre-processed by scripts in the 
>> Makefile before being passed to JTReg. JTReg will now the all the 
>> processing. The change depends upon improvements in JTReg since the test 
>> exclude mechanism was originally defined.
>> 
>> There are some changes in the reporting. Most obvious is that the 
>> excludelist.txt output file is no longer produced. The 'excluded' count in 
>> the summary report may be removed in a future reporting depending on whether 
>> the value can be calculated some other way.
>> 
>> Additional to the exclusion list processing changes some other changes are 
>> possible as a result of the changes to exclusion processing. In particular 
>> the obsolete (and incorrect) logic for determining the build path included 
>> in the test/Makefile is now removed. If no output directory is provided via 
>> ALT_OUTPUTDIR then a default location in the current directory is used, 
>> "testoutput". At some point in the future this could be improved to get the 
>> CONF from the build configuration but that is not currently possible.
>> 
>> Testing of this patch requires using a source build of JTReg as it requires 
>> one fix that is not in the promoted builds.
>> 
>> http://cr.openjdk.java.net/~mduigou/JDK-8015068/0/webrev/
>> 
>> Mike
> It's good to see this logic going away. Also defaulting the output directory 
> to TEST_ROOT (= pwd) is an improvement.
> 
> One thing that isn't completely clear to be is the whether the multiple 
> -exclude options work as advertised (because that hasn't worked for me in the 
> past and I always ended cat'ing them as per the old make file logic). I 
> assume you have tested with the Oracle jdk/test/closed repo present to verify 
> this.
> 

Yes. This is the fix that requires the updated jtreg. I won't push this change 
until jtreg is next promoted (b07)

> -Alan
> 

Reply via email to