On 07/24/13 09:44 PM, David Holmes wrote:
On 25/07/2013 8:48 AM, Tim Bell wrote:
Christian:

That's not true.  I've added Mac OS X support with the same change.

For building hotspot only, perhaps.  I want to build the entire product,
start to finish, using clang.

That's why I needed to touch these files:

common/autoconf/hotspot-spec.gmk.in
common/autoconf/toolchain.m4
make/jprt.properties

Yes but that doesn't explain the change now needed to os_bsd.cpp in hotspot.

I take it back. After syncing up with jdk8/master, the change to os_bsd.cpp is not required, so I removed that. I believe the MAX_PATH issues were resolved in an earlier fix.

New webrev (hotspot only):

   http://cr.openjdk.java.net/~tbell/8019470/hotspot.01/

The change in make/bsd/makefiles/gcc.make is required to link the adlc tool which is used early in the hotspot build.

Full webrev (OpenJDK):

http://cr.openjdk.java.net/~tbell/8019470/webrev.01/


Thanks in advance - we would like to get these changes checked in this week.

Tim


David
-----


Tim


On 07/24/13 02:59 PM, Christian Thalinger wrote:
On Jul 24, 2013, at 5:15 AM, Tim Bell <tim.b...@oracle.com> wrote:

On 07/24/13 04:43 AM, David Holmes wrote:
Hi Tim,

On 24/07/2013 8:15 AM, Tim Bell wrote:
Hello everyone-

This is a small set of changes to switch from gcc to clang when
building
So we already added support for clang as the compiler for hotspot -
is this just extending things to allow configure to select clang?
The earlier clang/hotspot activity was centered around Linux x86/x86_64.
That's not true.  I've added Mac OS X support with the same change.

-- Chris

on MacOS, and also enable building on MacOS 8.x
Have we already updated all the JPRT queues to have 10.8 macs versus
10.7 ones?
Yes, all the queues have 10.8 Macs, which have been test-only up
until now.

Here is the bug report:

http://bugs.sun.com/view_bug.do?bug_id=8019470

Here are the webrevs:

Hotspot only:

http://cr.openjdk.java.net/~tbell/8019470/hotspot/webrev.00/
src/os/bsd/vm/os_bsd.cpp

Again I'm confused. We already allowed building via clang so why
wasn't this change needed before?
This file is not used when building on Linux.

Tim

Thanks,
David

All of the changes:

   http://cr.openjdk.java.net/~tbell/8019470/webrev.00/

Thanks in advance.

Tim



Reply via email to