On 8/29/2013 7:16 AM, David Holmes wrote:
Hi Lois,
Is this still needed:
142 PCH_FLAG/unsafe.o = $(PCH_FLAG/NO_PCH)
given you no longer use -O0 ?
Hi David,
Yes, I believe so but this might be a cautionary change on my part. I
read the comment to imply that Clang does not support a precompiled
header compiled with an optimization level that is different than the
one used to compile the actual C++ file, this is why I chose to add
unsafe.o.
Lois
Thanks,
David
On 29/08/2013 3:56 AM, Lois Foltan wrote:
Please review the updated webrev:
open webrev at
http://cr.openjdk.java.net/~hseigel/bug_jdk8022407.2/
Bug:
bug link at https://bugs.openjdk.java.net/browse/JDK-8022407
Summary of fix:
The JDK 8 build on MacOS, when built with the Xcode 4.6.2 clang++
compiler, exhibited a compiler
optimization issue when prims/unsafe.cpp was compiled at the
default -Os level. As a work around
fix, knock the optimization level down down to -O1.
Tests: MacOS: built fastdebug & product images using clang++ (ran JTREG
& vm.quick.testlist)
built using llvm-g++ to verifyprims/unsafe.cpp remained
compiled at -Os
Thank you, Lois
