On 2013-09-10 22:30, Omair Majid wrote:
On 09/09/2013 01:40 PM, Omair Majid wrote:
On 09/05/2013 05:10 AM, Magnus Ihse Bursie wrote:
On 2013-09-04 21:26, Omair Majid wrote:
Over in Fedora-land, we are trying to build OpenJDK (using zero) on
s390(x) [1]. One of the changes needed is updating the platform.m4 file
to teach it about s390(x). The following webrev does that:
http://cr.openjdk.java.net/~omajid/webrevs/s390-platform/00/
My only concern here is about
VAR_CPU_ARCH=s390x
While I'm not 100% familiar about the specifics of the s390 family, nor
the s390 port, the general idea behind the VAR_CPU_ARCH variable, as
opposed to the VAR_CPU variable, is to unify 32 and 64 bit versions of
the same CPU.
Thanks for spotting this. Fixed:
http://cr.openjdk.java.net/~omajid/webrevs/s390-platform/01/
If there are no further concerns, shall I go ahead and push?
Looks good to me, feel free to push.
Thanks,
Omair
