Erik, Could I consider this as a review?
-Dmitry On 2013-08-29 16:02, Erik Joelsson wrote: > I think it fails when building with configure as AS will only get that > value when SPEC isn't set. > > /Erik > > On 2013-08-29 12:49, David Holmes wrote: >> Hi Dmitry, >> >> This needs to be reviewed by the hotspot group. >> >> I don't understand your change given we already had: >> >> AS = $(CC) -c -x assembler-with-cpp >> >> Isn't this something that was fixed very recently? >> >> Your change, as far as I can see, will also add the assembler-with-cpp >> to clang not just gcc. >> >> ??? >> >> David >> >> On 29/08/2013 7:09 PM, Dmitry Samersoff wrote: >>> David, >>> >>> Thank you for the comments. >>> >>> Please, take a look to updated webrev: >>> >>> http://cr.openjdk.java.net/~dsamersoff/JDK-8022617/webrev.03/ >>> >>> -Dmitry >>> >>> On 2013-08-29 04:41, David Holmes wrote: >>>> Dmitry, >>>> >>>> I don't think this is something that should be handled at the configure >>>> level. Hotspot compiler flags are handled in the hotspot makefiles. >>>> This >>>> should be in gcc.make. >>>> >>>> BTW your changeset should include the generated-configure.sh file not >>>> configure. And you would also need to regenerate and push the closed >>>> generated-configure.sh file. >>>> >>>> David >>>> >>>> On 28/08/2013 11:50 PM, Dmitry Samersoff wrote: >>>>> Hi Everyone, >>>>> >>>>> Please review small fix >>>>> >>>>> webrev: >>>>> >>>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8022617/webrev.02/ >>>>> >>>>> CR: >>>>> >>>>> http://bugs.sun.com/view_bug.do?bug_id=8022617 >>>>> >>>>> >>>>> Gory details: >>>>> >>>>> bsd_x86_64.s use macro to deal with OS X specific things. >>>>> >>>>> llvm-gcc preprocess .s and .S files and doesn't support .sx extension >>>>> recommended by GNU for case insensitive filesystem. >>>>> >>>>> Other operating systems doesn't preprocess .s files, so >>>>> bsd_x86_64.s >>>>> couldn't be compiled on other bsd systems. >>>>> >>>>> This patch enforce of preprocessing of all assembly sources by >>>>> command line options (-x assembler-with-cpp). >>>>> >>>>> -Dmitry >>>>> >>> >>> -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.
