The change looks fine to me. I assume you are going to be pushing this through 
TL?

Mike

On Oct 1 2013, at 09:25 , Alan Bateman wrote:

> 
> I need a reviewer for a trivial change to add an additional package to the 
> API docs.
> 
> The background to this one is that JAXP has historically included the API 
> package org.w3c.dom.events but not org.w3c.dom.views. As 
> org.w3c.dom.events.UIEvent defines a method that returns a type in 
> org.w3c.dom.views then it means there is a reference in the API to a type 
> that does not exist. This is being fixed for the upcoming JAXP 1.6 so we need 
> to update the generation of the javadoc to include the additional package.
> 
> The diff is trivial and inlined as it's not worth generating a webrev.
> 
> -Alan
> 
> 
> diff --git a/common/makefiles/javadoc/CORE_PKGS.gmk 
> b/common/makefiles/javadoc/CORE_PKGS.gmk
> --- a/common/makefiles/javadoc/CORE_PKGS.gmk
> +++ b/common/makefiles/javadoc/CORE_PKGS.gmk
> @@ -41,7 +41,6 @@
>   org.w3c.dom.stylesheets  \
>   org.w3c.dom.traversal    \
>   org.w3c.dom.ranges       \
> -  org.w3c.dom.views        \
>   org.omg.stub.javax.management.remote.rmi
> 
> #
> @@ -295,6 +294,7 @@
>   org.w3c.dom.events                             \
>   org.w3c.dom.bootstrap                          \
>   org.w3c.dom.ls                                 \
> +  org.w3c.dom.views                              \
>   org.xml.sax                                    \
>   org.xml.sax.ext                                \
>   org.xml.sax.helpers

Reply via email to