Hi Erik,
Thanks for the update! Looks good, but one minor comment:
SignJars.gmk
============
78:100:106:111-116 > 80 chars per line.
Brad
On 11/4/2013 2:19 AM, Erik Joelsson wrote:
New webrev posted: http://cr.openjdk.java.net/~erikj/8027698/webrev.jdk.02/
Addressed all comments below. I must have missed the save button before
generating the webrev when adding ucrypto.jar, but it's there now at least.
/Erik
On 2013-11-02 01:35, Bradford Wetmore wrote:
On 11/1/2013 3:34 AM, Erik Joelsson wrote:
Please review this simple fix, adding sunmscapi.jar and ucrypto.jar to
the list of jars to be signed by the sign-jars target. Since these jars
are platform dependent, they aren't always present.
Bug: https://bugs.openjdk.java.net/browse/JDK-8027698
Webrev: http://cr.openjdk.java.net/~erikj/8027698/webrev.jdk.01/
/Erik
makefiles/SignJars.gmk
======================
Overall: Some of the existing/new lines are greater than the standard
80 chars.
2: Some people update the Copyright date instead of waiting for RE to
do it. Feel free if you're one of those.
48 & 108: The RE process for signing jars for JDK 7/8 is completely
different than what was originally written/described for JDK 7. There
is an additional separate script that RE uses to include the
source_tips into the jar files, and then do the actual signing.
SignJars.gmk is here primarily for developer support.
47: Suggest changing to:
# SPECIAL NOTE TO JCE/JDK developers: The source files must eventually
# be built, signed, and then the resulting jar files MUST BE CHECKED
# INTO THE CLOSED PART OF THE WORKSPACE*. This separate step *MUST NOT
# BE FORGOTTEN*, otherwise a bug fixed in the source code will not be
# reflected in the shipped binaries.
#
# Please consult with Release Engineering, which is responsible for
# creating the final JCE builds suitable for checkin.
#
94: I don't see ucrypto.jar listed here.
108: Can you please update the code here to output:
The jar files built by the 'sign-jars' target are developer
builds only and *MUST NOT* be checked into the closed workspace.
Please consult with Release Engineering: they will generate
the proper binaries for the closed workspace.
@$(PRINTF) $(README-MAKEFILE_WARNING)
Since this bug is a subtask of JDK-8027266, I'll add a few more
comments to that bug. I'm guessing you'll probably want to address
separately.
Thanks, Erik!
Brad
