On 11/12/2013 10:03, Magnus Ihse Bursie wrote:

I'm glad to see this hackish stuff go away!

The build changes are mostly fine, however you remove the definition of BEANLESS_CLASSES_TARGETS but do not remove it everywhere. While it will work (expands to empty), it would be better if you fixed this line as well: $(IMAGES_OUTPUTDIR)/lib$(PROFILE)/rt.jar: $(IMAGES_OUTPUTDIR)/lib$(PROFILE)/_the.rt.jar.contents $(RT_JAR_MANIFEST_FILE) $(PROFILE_VERSION_CLASS_TARGETS) $(BEANLESS_CLASSES_TARGETS)
Thanks, I noticed this later too and will make sure to remove all vestiges before pushing.

-Alan

Reply via email to