Looks good to me.
/Erik
On 2014-01-07 04:45, Mike Duigou wrote:
I have updated my previous webrev to make the regular expressions simpler and
more portable based on feedback. I have tested on Mac, Solaris, Linux and
Cygwin.
http://cr.openjdk.java.net/~mduigou/JDK-8029512/1/webrev/
I did also note that the hgrc format allows for definitions of the form:
foo =
bar
where any line beginning with white space is considered a continuation line.
This is not easy to support with sed and I have not attempted to solve it in
this patch. (I did document the limitation).
To be honest the best approach may have been to write the script in Python and
use the ConfigParser package but I suspect that's what Mercurial does so this
would re-expose us to the original bug which apparently necessitated manual
parsing.
Cheers,
Mike
On Dec 3 2013, at 21:16 , Mike Duigou <mike.dui...@oracle.com> wrote:
Hello all;
This change addresses a problem discovered by Dave Pointon.
http://cr.openjdk.java.net/~mduigou/JDK-8029512/0/webrev/
If the .hg/hgrc file contains (perfectly legal) spaces around the = sign of an
assignment then the current script will fail to correctly read the path
definition. This patch corrects the parsing of the hgrc file and also protects
against empty results.
I plan to commit this to the JDK 9 repo first but expect that it should be
backported to JDK 8 and JDK 7 repos.
Mike
