On 2014-01-08 15:38, Erik Joelsson wrote:
Please review this fix for dependencies on windows pdb and map files.
While in the area, I took the liberty of cleaning up a bit and
removing some duplication.
Webrev: http://cr.openjdk.java.net/~erikj/8025936/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8025936
Thank you for cleaning this up! It looks much better now!
I have a minor nit:
432 $1_EXTRA_LDFLAGS +=
"-pdb:$$($1_OBJECT_DIR)/$$($1_NOSUFFIX).pdb" \
433 "-map:$$($1_OBJECT_DIR)/$$($1_NOSUFFIX).map"
434 $1_DEBUGINFO_FILES := $$($1_OBJECT_DIR)/$$($1_NOSUFFIX).map \
435 $$($1_OBJECT_DIR)/$$($1_NOSUFFIX).pdb
The change of order between map and pdb files does not really matter,
but got me confused at first look. But it's no big deal, if you don't
want to update the patch I will not blame you. :)
/Magnus
