Looks good to me too.
/Erik
On 2014-02-05 11:39, Magnus Ihse Bursie wrote:
Hi Jessica,
The patch looks fine. Thank you for finding this issue and posting a
patch!
I believe such trivial changes can be accepted without the hassle of
you signing the OCA, but I need to verify that.
/Magnus
On 2014-02-05 11:20, Man, Jessica wrote:
Thank you Magnus. Here is the patch:
# HG changeset patch
# User Jessica Man <jessica....@gs.com>
# Date 1391463887 0
# Mon Feb 03 21:44:47 2014 +0000
# Node ID 7ddb4db0e9ec3ce3d924cd51d6edee5b0258adf2
# Parent 135f0c7af57ebace31383d8877f47e32172759ff
Build fails if --with-alsa option is used due to incorrect ALSA link
parameter in autoconf script.
diff --git a/common/autoconf/libraries.m4 b/common/autoconf/libraries.m4
--- a/common/autoconf/libraries.m4
+++ b/common/autoconf/libraries.m4
@@ -554,7 +554,7 @@
fi
if test "x${with_alsa}" != x; then
- ALSA_LIBS="-L${with_alsa}/lib -lalsa"
+ ALSA_LIBS="-L${with_alsa}/lib -lasound"
ALSA_CFLAGS="-I${with_alsa}/include"
ALSA_FOUND=yes
fi
@@ -563,7 +563,7 @@
ALSA_FOUND=yes
fi
if test "x${with_alsa_lib}" != x; then
- ALSA_LIBS="-L${with_alsa_lib} -lalsa"
+ ALSA_LIBS="-L${with_alsa_lib} -lasound"
ALSA_FOUND=yes
fi
if test "x$ALSA_FOUND" = xno; then
-----Original Message-----
From: Magnus Ihse Bursie [mailto:magnus.ihse.bur...@oracle.com]
Sent: 05 February 2014 10:18
To: Man, Jessica [Tech]; 'build-dev@openjdk.java.net'
Subject: Re: [PATCH] For OpenJDK 8 and 9 to fix build issue when
--with-alsa option is used
Hi Jessica,
The attached patch was stripped by the mailing list server. Please
paste the patch inline in the mail, or provide a link to a web site
with the patch.
/Magnus
On 2014-02-05 11:09, Man, Jessica wrote:
Hi all,
This patch is for fixing a build issue with OpenJDK autoconf files.
If the --with-alsa option is used to point the build to the ALSA
library from a specific directory instead of using the system
default location, the JDK component will fail to build due to an
incorrect -l parameter being passed to ld and result in this error:
/usr/bin/ld: cannot find -lalsa
collect2: ld returned 1 exit status
Please review and let me know if further information is needed, or
if the patch should be modified in any way. Thank you.
Regards,
Jessica Man, Technology
Goldman Sachs International
Christchurch Court | 10-15 Newgate Street | London EC1A 7HD | Tel: +44
(0)20 7774 3695
The Goldman Sachs Group, Inc. All rights reserved.
See http://www.gs.com/disclaimer/global_email for important risk
disclosures, conflicts of interest and other terms and conditions
relating to this e-mail and your reliance on information contained
in it. This message may contain confidential or privileged
information. If you are not the intended recipient, please advise
us immediately and delete this message. See
http://www.gs.com/disclaimer/email for further information on
confidentiality and the risks of non-secure electronic
communication. If you cannot access these links, please notify us
by reply message and we will send the contents to you.
