Looks good to me. Just one question, since clang otherwise duplicates the gcc flags: is it correct to drop -fPIC in clang?
/Magnus > On 6 mar 2014, at 09:36, Erik Joelsson <erik.joels...@oracle.com> wrote: > > Hello, > > I was waiting for Magnus to look at this since he is more involved in this > code at the moment. I think it looks good ok, but would prefer if he got the > chance to look at it too. > > /Erik > >> On 2014-03-06 01:11, Henry Jen wrote: >> Ping! Is three any concern on this patch? I got JPRT reports no problem and >> other reports success. >> >> I hope we can get this in as early as we can because build is evloving >> quickly, and I think it only can get better after pushed for more tests. >> >> Cheers, >> Henry >> >>> On 02/26/2014 12:23 AM, Henry Jen wrote: >>> Hi, >>> >>> Please review a webrev to enable XCode5 build on Mac OS X, this webrev >>> add basic clang flags and detect Xcode version to set default toolchain >>> to clang for Xcode5 and after, otherwise set to gcc for Mac OS X. >>> >>> http://cr.openjdk.java.net/~henryjen/jdk9/8019470/1/webrev/ >>> >>> This patch build on Maverick with Xcode 5, but is not yet sufficient to >>> enable clang build on my Arch Linux, where I installed clang 3.4. There >>> are some undeclare identifier|function|type warnings/errors, the cause >>> of which is still under investigation, my guess lies in precompile >>> header, but I think that can be addressed later. >>> >>> Cheers, >>> Henry >
