On 20 mar 2014, at 11:25, Alan Bateman <alan.bate...@oracle.com> wrote:
> On 20/03/2014 09:13, Staffan Larsen wrote: >> >> Thanks! >> >> Still need someone to look at the actual code changes. >> >> > In webrev.01 then jdk/make/lib/ServiceabilityLibraries.gmk and > src/solaris/native/sun/management/MacosxOperatingSystem.c are showing up as > new files, I can't tell why that is. I had some trouble creating reviews for multiple repos now that "webrev -f” does not work. The review at http://cr.openjdk.java.net/~sla/8037825/webrev.01/jdk/ is the good one. > The code changes mostly look good to me. The only change that isn't very > clear (I had to stare at it for a few minutes) in log_messages.c where it's > now two calls to strftime. It might be useful to include a comment to explain > this, also maybe reduce the line length to make it easier for future > side-by-side reviews. Yes, that one was a bit messy. I cleaned it up and added some comments. Also remove the SCCS workarounds. http://cr.openjdk.java.net/~sla/8037825/webrev.02/ Thanks, /Staffan
