On 21/03/2014 11:59 AM, Alexander Smundak wrote:
I've revised the patch to have fold little endian and big endian
PowerPC64 architectures.
The build changes look much cleaner to me - thanks.
The patch for the hotspot repository is at
http://cr.openjdk.java.net/~martin/asmundak/8036767/hotspot/webrev.01
Top-level build's OPENJDK_TARGET_CPU_ENDIAN variable is carried over
to the Hotspot build as ZERO_ENDIANNESS, so the patch takes advantage
of this to set target-dependend compiler flags in
make/linux/makefiles/ppc64.make.
Why are you not using OPENJDK_TARGET_CPU_ENDIAN directly? Ah! Because it
doesn't reach down into the <arch>.make files. ZERO_ENDIANNESS does but
seems inappropriate if this is not Zero specific. (I'm also not seeing
how ZERO_ENDIANNESS reaches down that far either ??).
The accompanying patches for the other repositories are at:
top-level: http://cr.openjdk.java.net/~martin/asmundak/8036767/webrev.01
Seems ok.
jdk: http://cr.openjdk.java.net/~martin/asmundak/8036767/jdk/webrev.01
This change:
- LDFLAGS_SUFFIX := $(ALSA_LIBS) -ljava -ljvm, \
+ LDFLAGS_SUFFIX := $(ALSA_LIBS) $(LIBDL) $(LIBM) -lpthread -ljava
-ljvm, \
seems unrelated to endianness. Why is it needed, and why is it being
applied to all platforms?
Thanks,
David
