On 11/04/2014 23:42, Xueming Shen wrote:
Hi,
Please help review this changeset to upgrade the zip filesystem
provider implementation from
demo to a supported provider.
Back in JDK7 we created a demo file system provider for zip/jar files.
It is shipped in two forms,
one as a binary under lib/ext that works "out of the box" to support
zip/jar file access as a nio
filesystem, the second is source form with a BSD license.
We are now proposing to drop it as a demo and instead just "release"
it as a filesystem provider
that shipped with the JDK.
issue: https://bugs.openjdk.java.net/browse/JDK-8038500
webrev: http://cr.openjdk.java.net/~sherman/8038500/webrev
This looks good.
Mandy makes a good point about that only
com.sun.nio.zipfs.ZipFileSystemProvider needs to be public. That might
avoid having to put com.sun.nio.zipfs on the restricted package list too.
On basic.sh then this was originally needed in order to ensure that
zipfs.jar was on the class path. Since it in the ext directory then it
is not needed so Mandy's point about just moving the @test to the
individual tests is good.
-Alan.
