Hi, Erik. I think the change looks fine.
Thanks, iris -----Original Message----- From: Erik Joelsson Sent: Monday, May 05, 2014 6:28 AM To: build-dev Subject: RFR: JDK-8042348: Copyright link in Javadoc page for Java SE 8 Hello, Please review this small patch to javadoc generation. The Copyright footer, at the bottom of the page, should be a link, but in jdk8 and 9 it isn't. This is caused by COPYRIGHT_URL being empty if JDK_MINOR_VERSION is not 7. I see no reason to have a jdk version dependency on this URL since the value isn't dependent on jdk version. This will likely need a backport to 8 too. Bug: https://bugs.openjdk.java.net/browse/JDK-8042348 Patch inline: diff -r 183052721803 make/Javadoc.gmk --- a/make/Javadoc.gmk +++ b/make/Javadoc.gmk @@ -115,10 +115,7 @@ DOCSDIR_URL = {@docroot}/$(GET2DOCSDIR) # Url to copyright html file -COPYRIGHT_URL-7 = $(DOCSDIR_URL)/legal/cpyr.html -# This isn't added in old build yet. -#COPYRIGHT_URL-8 = $(DOCSDIR_URL)/legal/cpyr.html -COPYRIGHT_URL = $(COPYRIGHT_URL-$(JDK_MINOR_VERSION)) +COPYRIGHT_URL = $(DOCSDIR_URL)/legal/cpyr.html # Url to bug filing site
