Hi Erik , Thanx for that, bizarrely, I never even considered that JIRA might choose to apply a little re-formatting but it undoubtedly has.
Anyway, I'm a not little uncertain of your assertion 'The problem then is that there will be no java launcher present to query for version information' - would you happen to know if there is a definition of the (expected) contents of a hotspot build - as you can probably tell, I rather assumed that a bin directory (and indeed bin/java) would be in there. TIA & rgds , -- Dave Pointon FIAP MBCS Now I saw, tho' too late, the folly of beginning a work before we count the cost and before we we judge rightly of our strength to go thro' with it - Robinson Crusoe On 8 May 2014 08:56, Erik Joelsson <erik.joels...@oracle.com> wrote: > Hello Dave, > > Adding this information certainly makes sense. While probably not a very > common usecase, it is currently possible to point "--with-import-hotspot" > to the dist directory of a Hotspot build. The problem then is that there > will be no java launcher present to query for version information. Could > you please add a condition on the existance of > $with_import_hotspot/bin/java before trying to run it? If it's not there, > the version will simply be unknown. > > The patch looks like it's missing indentation. This might be because of > formatting in JIRA, but in case it's not, please indent the if statements > properly with 2 spaces. > > /Erik > <snip> >
