Hello David,
I like that you incorporate the existing sysroot settings for this. I
wonder though, what is the difference between --with-macosx-sdk-path and
--with-sysroot? Do we really need two parameters for this? If it's
actually a sysroot, couldn't we replace all uses of this variable with
just SYSROOT and keep it more generic?
/Erik
On 2014-05-23 08:16, David DeHaven wrote:
Build systems take such a long time work on...
I've changed the logic, I think for the better. I hijacked --with-sysroot,
SYSROOT is set to the SDK path and I stuffed the -iframework argument alongside
the -isysroot arg in SYSROOT_CFLAGS and it works very nicely. Now the only
change that's peppered throughout the forest is adding $(MACOSX_SDK_PATH) to
the hard coded JavaVM.framework and ApplicationServices.framework paths, not to
mention everything gets -isysroot/-iframework and not just the parts that
needed JavaVM or ApplicationServices. The added SYSROOT logic is Mac specific
so other platforms should be unaffected, JPRT should tell otherwise if not...
I also added two configure args:
--with-macosx-sdk name of Mac OS X SDK to build with, e.g., macosx10.7
[macosx]
--with-macosx-sdk-path specify path of Mac OS X SDK to build with [probed]
Please note that this version is against jdk9-dev with the following patches
imported from other forests:
hotspot:
JDK-8043164 (jdk9/hs)
jdk:
JDK-8042440 (jdk9/client)
JDK-8043646 (jdk9/client)
JDK-8003900 (jdk9/client)
Updated patches:
http://cr.openjdk.java.net/~ddehaven/8043340/v1/base
http://cr.openjdk.java.net/~ddehaven/8043340/v1/hotspot
http://cr.openjdk.java.net/~ddehaven/8043340/v1/jdk
-DrD-
