Hello,
Just re-asserting the "please review" interrupt -- I'd prefer to get
this pushed soon, before the good javadoc properties get perturbed by
accident!
Thanks,
-Joe
On 06/26/2014 02:57 PM, Joe Darcy wrote:
Hello,
Two JDK 9 fixes to make/Javadoc.gmk for review:
JDK-8048302: Update bug reporting URL in make/Javadoc.gmk
JDK-8048321: Enabled doclint warnings in docs build
http://cr.openjdk.java.net/~darcy/8048302.0/
The two portions of the patch below should be clear.
The old sun.com URL for reporting bugs was retired and replaced with a
java.com URL.
After some recent fixes in langtools, the langtools API sources are
doclint clean, meaning the doclet, taglet, and tree API doc command
should enforce that property using the doclint option.
The core API build is doclint clean on a few properties and those are
also enabled by this change.
I verified a docs build succeeds with this changes.
Thanks,
-Joe
diff -r 9f96a36ef77c make/Javadoc.gmk
--- a/make/Javadoc.gmk Tue Jun 24 20:29:52 2014 -0700
+++ b/make/Javadoc.gmk Thu Jun 26 14:53:57 2014 -0700
@@ -118,7 +118,7 @@
COPYRIGHT_URL = $(DOCSDIR_URL)/legal/cpyr.html
# Url to bug filing site
-BUG_SUBMIT_URL = http://bugreport.sun.com/bugreport/
+BUG_SUBMIT_URL = http://bugreport.java.com/bugreport/
# Common line for how to submit a bug or rfe
BUG_SUBMIT_LINE = <a href="$(BUG_SUBMIT_URL)">Submit a bug or
feature</a>
@@ -366,7 +366,7 @@
$(COREAPI_OPTIONS_FILE): $(COREAPI_OVERVIEW)
$(prep-target)
@($(call OptionOnly,$(COMMON_JAVADOCFLAGS)) ; \
- $(call OptionOnly,-Xdoclint:none) ; \
+ $(call OptionOnly,-Xdoclint:html,reference,syntax) ; \
$(call OptionPair,-sourcepath,$(RELEASEDOCS_SOURCEPATH)) ; \
$(call OptionPair,-encoding,ISO-8859-1) ; \
$(call OptionPair,-tag,beaninfo:X) ; \
@@ -442,7 +442,7 @@
$(DOCLETAPI_OPTIONS_FILE):
$(prep-target)
@($(call OptionOnly,$(COMMON_JAVADOCFLAGS)) ; \
- $(call OptionOnly,-Xdoclint:none) ; \
+ $(call OptionOnly,-Xdoclint:all) ; \
$(call OptionPair,-sourcepath,$(RELEASEDOCS_SOURCEPATH)) ; \
$(call OptionPair,-encoding,ascii) ; \
$(call OptionOnly,-breakiterator) ; \
@@ -499,7 +499,7 @@
$(TAGLETAPI_OPTIONS_FILE):
$(prep-target)
@($(call OptionOnly,$(COMMON_JAVADOCFLAGS)) ; \
- $(call OptionOnly,-Xdoclint:none) ; \
+ $(call OptionOnly,-Xdoclint:all) ; \
$(call OptionPair,-sourcepath,$(RELEASEDOCS_SOURCEPATH)) ; \
$(call OptionPair,-encoding,ascii) ; \
$(call OptionOnly,-nonavbar) ; \
@@ -1074,7 +1074,7 @@
$(TREEAPI_OPTIONS_FILE):
$(prep-target)
@($(call OptionOnly,$(COMMON_JAVADOCFLAGS)) ; \
- $(call OptionOnly,-Xdoclint:none) ; \
+ $(call OptionOnly,-Xdoclint:all) ; \
$(call OptionPair,-sourcepath,$(RELEASEDOCS_SOURCEPATH)) ; \
$(call OptionPair,-encoding,ascii) ; \
$(call OptionPair,-doctitle,$(TREEAPI_DOCTITLE)) ; \
