I improved the comments as suggested and fixed a problem with a blank line being output when OptionOnly is called with empty ADDITIONAL_JAVADOCFLAGS.
webrev: http://cr.openjdk.java.net/~mduigou/JDK-8051010/1/webrev/ Mike On Jul 17 2014, at 11:28 , Mike Duigou <[email protected]> wrote: > > On Jul 17 2014, at 11:24 , Alan Bateman <[email protected]> wrote: > >> On 17/07/2014 18:58, Mike Duigou wrote: >>> Hello all; >>> >>> In Java 8 the core JDK API Javadoc started using several new custom javadoc >>> tags. Other javadoc bundles would like to use the same tags and it's a good >>> idea to be generating all of the javadoc bundles as consistently as >>> possible. This changeset provides support for the new custom javadoc tags >>> to all bundles generated by Javadoc.gmk. It also includes an RFE to make >>> the @jls and @jvms tags available to all bundles as well. >>> >>> jbsbug: https://bugs.openjdk.java.net/browse/JDK-8051010 >>> webrev: http://cr.openjdk.java.net/~mduigou/JDK-8051010/0/webrev/ >>> >>> Mike >> This looks good to me except for repeated comments "Common javadoc options >> used by all". Maybe it should just be removed only the JLS see tag. > > OK I will fix that before push. > > Thanks, > > Mike
