On 8/15/2014 1:49 AM, Magnus Ihse Bursie wrote:
*** Issues regarding modules.xml ***
The new modules.xml and associated Java tools and make files seems
rather confusing to me. I understand some of the mysteries here are
due the the fact that the file has moved around during development.
Nevertheless, such historical relics should be removed when the code
is ready to be pushed to mainline. More concretely:
One thing to say about the modules.xml file is that it's not just for
jdeps to use (verifying the module boundaries). It is an essential
documentation to describe the module definition for the JDK [1] and will
go away once the module system is in place and not all the modules are
in the jdk repo and hence it's placed in the top level repo.
* ModulesXml.gmk referes to make/data/checkdeps/modules.xml. This file
does not exist. I believe this should be the $(TOPDIR)/modules.xml.
That reference in the comment that we missed to update when moving the
file. Fixed.
Mandy
[1] https://bugs.openjdk.java.net/browse/JDK-8051618
