On 11/09/2014 10:38, Magnus Ihse Bursie wrote:
On 2014-09-10 18:28, Valerie Peng wrote:
Could someone please review this build related change for moving
sunpkcs11-solaris.cfg file to the pkcs11 module?
Webrev: http://cr.openjdk.java.net/~valeriep/8039898/webrev.00/
Looks good. However, I'll give the same feedback to you as I just
recently did to Phil:
The webrev shows the file as being moved outside the control of
mercurial. That is, if you do "hg mv" to move the file, the history of
the file will be kept intact. Otherwise it will look like a new file
in the repo. (Sometimes this doesn't show up properly in the webrev,
apologies if you already did this.)
For webrev then I think it depends on whether the changes have been
committed or not. If you do a hg mv and then webrev -N before committing
then it will show as a move. If you commit and then generate the webrev
then it looks like a delete + new file. Maybe there is an opportunity
for someone to see if webrev can be made a bit smarter.
-Alan
