Hello,
On 2014-10-10 18:52, Omair Majid wrote:
Hi,
The DEBUG_CLASSFILES variable seems to be completely unused but still defined
in the makefiles in jdk9 and jdk8u.
$ grep -rn DEBUG_CLASSFILES
Binary file jaxp/.hg/store/data/make/_makefile.i matches
Binary file jaxws/.hg/store/data/make/_makefile.i matches
build/config.status:876:S["DEBUG_CLASSFILES"]="false"
build/config.log:1391:DEBUG_CLASSFILES='false'
build/hotspot-spec.gmk:45:DEBUG_CLASSFILES:=false
common/autoconf/jdk-options.m4:219: DEBUG_CLASSFILES="false"
common/autoconf/jdk-options.m4:227: DEBUG_CLASSFILES="true"
common/autoconf/jdk-options.m4:235: DEBUG_CLASSFILES="true"
common/autoconf/jdk-options.m4:243: DEBUG_CLASSFILES="false"
common/autoconf/jdk-options.m4:315: AC_SUBST(DEBUG_CLASSFILES)
common/autoconf/generated-configure.sh:884:DEBUG_CLASSFILES
common/autoconf/generated-configure.sh:14627: DEBUG_CLASSFILES="false"
common/autoconf/generated-configure.sh:14635: DEBUG_CLASSFILES="true"
common/autoconf/generated-configure.sh:14643: DEBUG_CLASSFILES="true"
common/autoconf/generated-configure.sh:14651: DEBUG_CLASSFILES="false"
common/autoconf/hotspot-spec.gmk.in:45:DEBUG_CLASSFILES:=@DEBUG_CLASSFILES@
I think it's still used by the hotspot makefiles (sa-jdi.jar). Seems
weird that we still set it in configure but then ignore the value in the
jdk build. I would vote for resurrecting the option.
In Fedora builds of OpenJDK 7, we used to set this to compile javacode
with the -g flag. The new build, through SetupJavaCompilation,
completely ignores this flag (looks like "JAVAC_FLAGS" controls this
now). Would it be worth it to bring back DEBUG_CLASSFILES flag? Or should
it be completely removed?
On a slightly related note, what do people think about adding a new
"DEBUG_LEVEL" that is basically the same as release, except it sets
DEBUG_BINARIES and DEBUG_CLASSFILES/JAVAC_FLAGS to get all debug info?
I'm not sure if even more debug levels is the right way to go. It seems
hard to name and that probably means it will be hard to understand.
Perhaps completely separating native debug level and java debug level
would make more sense?
/Erik
Thanks,
Omair
