Re: jmx-dev RFR 8060692 Delete com/sun/jmx/snmp and sun/management/snmp from OpenJDK

[Erik Joelsson]

Looks good now.

/Erik

On 2014-10-16 12:20, shanliang wrote:

Hi,

Here is the new version:
   http://cr.openjdk.java.net/~sjiang/JDK-8060692/02/

./02/jdk9-open/ has 2 more deleted files than in ./01/jdk9-jdk-src/
    test/com/sun/jmx/snmp/
       SnmpOidHashCode.java, TimeTicksWrapping.java

./02/jdk9-make/ has one more modified:
   make/common/Modules.gmk

Thanks,
Shanliang

Mandy Chung wrote:

On 10/15/2014 9:04 AM, Mandy Chung wrote:

Hi Shanliang,

On 10/15/2014 8:19 AM, shanliang wrote:

Here is the new version:

http://cr.openjdk.java.net/~sjiang/JDK-8060692/01/

Thanks for taking this on. The fix looks okay. I think you should also take out:

make/common/Modules.gmk
line 45:   JAVA_MODULES_FILTER := jdk.snmp

Also jdk/test/com/sun/jmx/snmp should be removed too.

Mandy