On 2014-11-05 17:13, Volker Simonis wrote:
Hi Magnus,
I've looked at the change and I think it looks good.
For any case I've also run an AIX build with your change applied and
didn't encounter any problems.
So thumbs up from me!
Thanks!
Regards,
Volker
PS: how did you produce a webrev from two repositories - do you have a
special version of webrev?
No special version, just the latest from the webrev repo. Use the -f
switch to include sub-repos. For historical reasons it's named "-f", for
forest, but it is now converted to use the tree extension. (I did ran
into an issue with the new tree extension support since I used nawk
instead of gawk; a patch for that is under review.)
And what's the best way to import such a change into mercurial (apart
from 'patch'). I manually edited the patch file to make 'compatible'
with 'qimport' but maybe there's a better way?
I have no idea. :-) I think you'll need to use patch, since mercurial do
not know about subrepos internally. Is there a problem with using patch?
Maybe the trees extensions will need to implement a timport..?
/Magnus
