On 11/21/2014 03:46 PM, Magnus Ihse Bursie wrote: > > Almost there! :-) > > 1) Comment in config.sub identifies it as config.guess. > > 2) As as understand it, your first attempt is to just dispatch through > to autoconf-config.sub if there is no aarch64 arguments. Good! However, > the code could be made clearer: The dot is small and some comment > clarifying that we will exit after this line might be helpful to the > reader.
I could just add exit $? after the call to autoconf-config.sub. That way it does not matter whether autoconf-config.sub exits or not, and the reader can tell that we don't go any further. > Also, you're using a $sub_args which is not defined. This will > not break, but it makes the reader confused. (I suspect copy/paste glitch.) Oh, bah. Right you are. > 3) The webrev indicates that the original config.sub was renamed to > config.sub.orig, instead of autoconf-config.sub. How strange. I'll fix that. > But since that is how > it is called in the new config.sub wrapper, the patch is unlikely to > work. When you test this, make sure you have no lingering files in your > workspace that can mess up the results. (e.g. no "?" files in hg status). OK. Andrew.
