Yes, it can be modified. My preferred variant for file existence
checking in make is "ifneq ($(wildcard /path/to/file), )". Also, in
Gensrc-jdk.jdi.gmk, I would probably like some other logical condition
to check on than sa-jdi.jar. We will address this at some point soon.
/Erik
On 2014-12-03 15:47, Dave Pointon wrote:
Hmmm ,
Would it not be possible to modify Xerxes' suggested patch to do
something along the lines of ...
# sa-jdi.jar do not exist for Itanium and zero
ifeq ($(shell if test -a $(HOTSPOT_DIST)/lib/sa-jdi.jar; then echo N;
fi),N)
SA_TARGETS += \
$(JDK_OUTPUTDIR)/modules/jdk.hotspot.agent/_the.sa.jar.unpacked \
$(SUPPORT_OUTPUTDIR)/gensrc/jdk.hotspot.agent/_the.sa
<http://the.sa>.services
endif
Just a thought
--
Dave Pointon FIAP MBCS -
contractor engaged by IBM
Now I saw, tho' too late, the folly of beginning a work before we
count the cost and before we we judge rightly of our strength to go
thro' with it - Robinson Crusoe
On 3 December 2014 at 14:30, Erik Joelsson <erik.joels...@oracle.com
<mailto:erik.joels...@oracle.com>> wrote:
Hello Xerxes,
Thanks for the suggestion. I have created
https://bugs.openjdk.java.net/browse/JDK-8066589 to track this
issue. Unfortunately we won't have time to fix it before pushing
JEP 220 to jdk9. I hope this won't inconvenience you too much.
Your suggested patch does correctly highlight the problem areas,
but will not work since gnu make does not accept shell logic
outside of recipes or $(shell ...) constructs.
/Erik
<snip>
