On 2015-01-07 16:41, Roman Kennke wrote:
Hi Erik,
I made some fixes to the build machinery to be able to build Shark:
http://cr.openjdk.java.net/~rkennke/shark-build-top/
Looks fine, but the generated configure script needs to be generated by
the script as it also updates a timestamp inside the file. We will still
need to update the closed version of the generated script in sync with
this. I will be happy to push both when review has passed if you like.
That would be great.
http://cr.openjdk.java.net/~rkennke/shark-build-hotspot/
That looks like a simple typo. Looks good to me. This is in hotspot
however so will need to go through a hotspot forest and requires 2
reviewers.
ok, I will finish my code-changes to hotspot and propose the whole bunch
to hotspot-dev separately as you suggested.
Sounds like a good idea, thanks!
http://cr.openjdk.java.net/~rkennke/shark-build-jdk/
Is the contents of the conditionals for SERVER, ZERO and ZEROSHARK the
exact same? Perhaps change into one conditional like this?
Please have a look at the updated simpler patch I posted right after the
first one:
http://cr.openjdk.java.net/~rkennke/shark-build-jdk/webrev.01/
That indeed looks better.
Do you have a bug for this?
/Erik
Regards,
Roman
