On 2015-01-09 15:34, Erik Joelsson wrote:
Hello,
Please review this patch which fixes the verify-modules target when
running bootcycle build, and also reenables verify-modules when
running "make images".
There were two problems:
* The bootcycle build configuration was broken so that both the normal
and the bootcycle build used the same HOTSPOT_DIST directory. The
consequence of this was that verify-modules worked when run on its
own, but not if bootcycle-images had been run before. This is fixed in
bootcycle-spec.gmk.in.
* Since javac in JDK 9 no longer emits classes for implicitly compiled
sources, certain classes in sa-jdi.jar were not compiled during the
bootcycle build. I fixed this by adding the missing classes to
sa.files. Not having the classes there might have been intentional (in
at least some cases), but since they were compiled anyway, I felt it
safer to just add them to the list to fix this issue. If these classes
shouldn't be included, then they need to be properly removed in a
followup fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8067479
Webrev: http://cr.openjdk.java.net/~erikj/8067479/webrev.01/
Since this is changing hotspot, I assume it will need to go in through
a hotspot forest. Which one?
Top level build changes look good to me. Can't say anything about the SA
stuff.
/Magnus
