On 2014-12-10 12:30, Erik Joelsson wrote:
Hello,
Embarrassingly enough, my last fix for the -L and space problem wasn't
correct. Here is a new fix where I'm reverting the macro definitions
from using define to simple = assignment. The latter automatically
strips leading whitespace and IMO fits better for the type of macro
that should not be called with $(eval ). (See bug for more detailed
explanation).
This time I made sure to grep the build log on a mac for '-L ' to make
sure I didn't miss anything.
Stuart: could you make sure this patch works since I can't repro the
actual failure?
Bug: https://bugs.openjdk.java.net/browse/JDK-8067060
Webrev: http://cr.openjdk.java.net/~erikj/8067060/webrev.jdk.01/
Looks good to me.
I prefer the "define" style for macros since it's more clear (at least
to me :)) that it's a macro and not just a simple definition, but I
agree that when it breaks otherwise, as it would in this case, the =
assignment is useful.
/Magnus
