Hello,
Catching up on email after the holidays...
On 12/9/2014 10:39 PM, Erik Joelsson wrote:
First, congratulations on almost being done fixing all the warnings!
When removing the last warning exception, perhaps it's time to change
the comment next to this line too?
A fair point!
How about
--- old/make/common/SetupJavaCompilers.gmk 2015-01-09
15:26:49.930781479 -0800
+++ new/make/common/SetupJavaCompilers.gmk 2015-01-09
15:26:49.850781479 -0800
@@ -1,5 +1,5 @@
#
-# Copyright (c) 2011, 2014, Oracle and/or its affiliates. All rights
reserved.
+# Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights
reserved.
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
#
# This code is free software; you can redistribute it and/or modify it
@@ -30,9 +30,9 @@
DISABLE_WARNINGS :=
-Xlint:all,-deprecation,-unchecked,-rawtypes,-cast,-serial,-dep-ann,-static,-fallthrough,-try,-varargs,-empty,-finally
-# To build with all warnings enabled, do the following:
+# If warnings needs to be non-fatal for testing purposes use a command
like:
# make JAVAC_WARNINGS="-Xlint:all -Xmaxwarns 10000"
-JAVAC_WARNINGS := -Xlint:all,-deprecation -Werror
+JAVAC_WARNINGS := -Xlint:all -Werror
# The BOOT_JAVAC setup uses the boot jdk compiler to compile the tools
# and the interim javac, to be run by the boot jdk.
(Also viewable at http://cr.openjdk.java.net/~darcy/8067099.0/)
Thanks,
-Joe
/Erik
On 2014-12-10 02:59, joe darcy wrote:
Hello,
The time approaches when the one remaining category of lint warning
still present in the jdk repo, deprecation, will be eliminated. In
anticipation of that happy day, please review this simple patch to
enable the warning in the build:
diff -r f7c11da0b048 make/common/SetupJavaCompilers.gmk
--- a/make/common/SetupJavaCompilers.gmk Thu Dec 04 15:21:09 2014
-0800
+++ b/make/common/SetupJavaCompilers.gmk Tue Dec 09 17:30:32 2014
-0800
@@ -32,7 +32,7 @@
# To build with all warnings enabled, do the following:
# make JAVAC_WARNINGS="-Xlint:all -Xmaxwarns 10000"
-JAVAC_WARNINGS := -Xlint:all,-deprecation -Werror
+JAVAC_WARNINGS := -Xlint:all -Werror
# The BOOT_JAVAC setup uses the boot jdk compiler to compile the tools
# and the interim javac, to be run by the boot jdk.
As usual for this kind of change, a jprt job will be used to verify
the fix is valid on all platforms, etc.
Thanks,
-Joe
