On 2015-01-15 16:32, Erik Joelsson wrote:
Looks good to me.
Thanks. It turned out that I needed to integrate this via jdk9-client
instead of jdk9-dev, as usual, to support the upcoming build-infra work,
and to avoid an unneccessary merge clash with the changes of Visual
Studio 2012 in jdk9-client. That in turn means I had to drop the fixes
to compare.sh, since they depended on the resolved merge conflicts that
I pushed the other day to jdk9-dev (but which are not as of yet in
jdk9-client). Phew. I'll return to the compare.sh fixes in a follow-up
bug when everything that's relevant has been integrated everywhere. :)
/Magnus
/Erik
On 2015-01-15 16:23, Magnus Ihse Bursie wrote:
This fix is the result of preparatory work in the build-infra
project. It includes:
* Remove duplicate detection of comm on Windows
* compare.sh enhancements and bug fixes
* Do not fail in SetupFoo macros on empty arguments
* Minor JavaCompilation enhancements
* Makefile warns for unknown control variables
* Improved "make help"
Bug: https://bugs.openjdk.java.net/browse/JDK-8069064
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8069064-fixes-from-build-infra/webrev.01
/Magnus