On 28/01/2015 10:46, Erik Joelsson wrote:
Hello,

Please review this followup fix for the vardeps patch (JDK-8069261). It seems that in Cygwin, when running gnu make 3.82, whitespace isn't stripped in the exact same way as on other versions of gnumake that I have tested (4.0 on all platforms, 3.81 on linux). The fix to this problem was to change the string equals macro that I created and strip the arguments in that.

Added a test that reproduces the problem.

Bug: https://bugs.openjdk.java.net/browse/JDK-8071651
Webrev: http://cr.openjdk.java.net/~erikj/8071651/webrev.root.01/
The stripping in MakeBase.gmk looks okay to me. Also the test to check equals looks okay too.

-Alan

Reply via email to