On 2015-01-30 12:01, Magnus Ihse Bursie wrote:
On 2015-01-30 11:51, Erik Joelsson wrote:
Hello,

New webrev: http://cr.openjdk.java.net/~erikj/8062223/webrev.root.02/

Fixed the anti pattern.

Sort of. :-) You still ignore the flag silently if it is not supported. I would prefer if a AC_MSG_WARN or AC_MSG_NOTICE in that case. If the user has explicitely given an argument, I think they deserves to know that is was to no effect. But then again, that's no regression so I accept if you will not fix it now.

You are right, I think I got it right this time:
http://cr.openjdk.java.net/~erikj/8062223/webrev.root.03/

/Erik

Also made it a fatal error to try to use ccache if the compiler does not support the option as it's unclear if it really works correctly then. On the other hand, that option has been around for a long time so it will never fail.
Sounds good.

/Magnus

Reply via email to