Magnus:

Looks good to me as well.

Tim

On 02/10/15 14:49, Erik Joelsson wrote:
Looks good.

/Erik

On 2015-02-10 15:43, Magnus Ihse Bursie wrote:
It turned out that an internal Oracle tool produces *.bc files in the build support directories. When trying to strip those files, we fail.

This fix will filter out such files in StripBinaries.gmk:

diff --git a/make/StripBinaries.gmk b/make/StripBinaries.gmk
--- a/make/StripBinaries.gmk
+++ b/make/StripBinaries.gmk
@@ -53,7 +53,7 @@
 endif

 # Don't include debug info for executables.
-ALL_CMDS_SRC := $(filter-out %.debuginfo %.diz %.map %.pdb, \
+ALL_CMDS_SRC := $(filter-out %.bc %.debuginfo %.diz %.map %.pdb, \
$(shell $(FIND) $(SUPPORT_OUTPUTDIR)/modules_cmds -type f -o -type l))
 COPY_CMDS_SRC := $(filter %.cgi, $(ALL_CMDS_SRC))
 STRIP_CMDS_SRC := $(filter-out $(COPY_CMDS_SRC), $(ALL_CMDS_SRC))

/Magnus


Reply via email to