Hi David, Thomas' initial change which started this discussion, i.e.
https://bugs.openjdk.java.net/browse/JDK-8072935 http://cr.openjdk.java.net/~stuefe/webrevs/8072935/webrev.01/webrev/ adds the missing newline to src/share/vm/services/writeableFlags.cpp. It should be pushed to jdk9-hs-rt/ (preferably before jdk9-hs-rt gets pushd to jdk9-hs and jdk9-dev). For this we need a sponsor. Maybe you can volunteer:) Independently of this fix I've suggested to add a check for missing newline at the end of file to jcheck. I've meanwhile opend a corresponding bug and submitted a patch for review to the code-tools-dev list: http://cr.openjdk.java.net/~simonis/webrevs/2015/7901298/ https://bugs.openjdk.java.net/browse/CODETOOLS-7901298 But again, this will only prevent such errors in the future. The current file which has no newline at the end has to be fixed with Thomas' patch. Regards, Volker On Fri, Feb 13, 2015 at 11:09 AM, David Holmes <david.hol...@oracle.com> wrote: > On 13/02/2015 7:23 PM, Volker Simonis wrote: >> >> Hi, >> >> could somebody please sponsor and push this change. > > > Push it to where, as what? I thought you wanted a jcheck addition. > > David > > >> Thanks, >> Volker >> >> >> On Fri, Feb 13, 2015 at 7:49 AM, Martin Buchholz <marti...@google.com> >> wrote: >>> >>> Source files should have exactly one trailing newline. >>> >>> find -iregex '.*\.\(java\|txt\|c\|cc\|h\|hpp\|cpp\)$' | xargs perl -0777 >>> -ne >>> 'print "Must have exactly one trailing newline: $ARGV\n" unless >>> m~[^\n]\Z~s' >>> >>> >
