On 2015-03-25 23:42, David Holmes wrote:
New webrev:
http://cr.openjdk.java.net/~dholmes/8072740/webrev.v2/
This doesn't define the ALT_JVMCFG_SRC in the open file - which makes
more sense for the clean up.
I was unsure if $(wildcard xxx) would behave okay if xxx was an
undefined variable, but it seems to handle it okay.
Looks good to me.
Make evaluates undefined variables as the empty string. So it's
perfectly safe.
In newer GNU make versions, there is a flag available for warning for
the use of uninitialized variables. While it would be good to turn it
on, we have too many instances where we assume that an undefined
variables is okay to read from. :-(
/Magnus
Thanks,
David
On 25/03/2015 7:08 PM, David Holmes wrote:
I've been asked to make a change so a new webrev will be firthcoming.
Thanks,
David
On 25/03/2015 1:43 PM, David Holmes wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8072740
webrev: http://cr.openjdk.java.net/~dholmes/8072740/webrev/
Simple fix, contributed by Dean Long, that allows the jvm.cfg file
to be
located in the "closed" location. The arm and ppc jvm.cfg files can
then
be moved to that "closed" location.
Thanks,
David
