On 6/8/2015 9:57 PM, Jan Lahoda wrote:
On 9.6.2015 01:31, Daniel D. Daugherty wrote:
 >
http://cr.openjdk.java.net/~ihse/JDK-8085822-JEP-223-initial-patch/webrev.01 langtools/src/java.compiler/share/classes/javax/lang/model/SourceVersion.java

     old L171:                 case "1.9":
     new L171:                 case "9":
         Should this logic support both versions? Will dropping
         "1.9" here prevent a pre-version changeset JVM from
         being dropped into a JDK for triage purposes?

Granted we don't often triage 'javac' with different JVMs, but...


+1 on keeping both "1.9" and "9" here. javac can be used independently on the rest of JDK to some extent, so support for running it on older builds of JDK 9 seems reasonable to me. (I wonder if current JDK 9 javac should be prepared for the new version scheme in advance.)

Yes, I think for the most part langtools seems to be working in the sandbox repo, with these changes, the remaining work is to align the version and fullversion of langtools/test to be
compliant to the JDK version.

Kumar


Jan

Reply via email to