> On Jun 12, 2015, at 1:07 PM, Pete Brunet <peter.bru...@oracle.com> wrote: > > Thanks Mandy, The new patch is at > http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.04 >
Looks good. Thanks. > On 6/10/15 6:29 PM, Mandy Chung wrote: >>> On Jun 10, 2015, at 3:33 PM, Pete Brunet <peter.bru...@oracle.com> wrote: >>> >>> Due to some other priorities it's been over 2 months since the last webrev. >>> An update is here: >>> http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.03 >> BarProvider.java >> You can use try-with-resource >> try (PrintWriter writer = new PrintWriter("BarProvider.txt”)) { >> writer.println("BarProvider-activated”); >> } catch (IOException e) { >> throw new UncheckedException(e); >> } >> >> That will close the writer. I think you should rethow IOException instead >> of swallowing it. >> >> Same comment to other provider implementation. > Done, using UncheckedIOException. >> >> Load.java >> The test should clean up all files before starting loading the providers >> since someone may run the test standalone multiple times on the same >> directory. > Done. I was removing them in the shell script but I've moved that now > to the Java code. I had to add delete to the permissions in > accessibilityProvider.sp. I missed that in the shell test. The new version is good. Thanks Mandy
